ZoneMinder netdata collector
I made a collector to capture and monitor ZoneMinder data. ZoneMinder is an open source video surveillance software. I did the collector as I had the need to monitor my cameras.
Code can be found here: https://github.com/pepe386/netdata-zoneminder
I wish to do a pull request, but before I have some questions:
The zoneminder python collector uses a couple of external libraries (requests and PyJWT). Is this acceptable for a pull request? I can include the libraries in the python_modules directory for the PR.
I originally wanted to use UrlService, but I need to do both post and get http requests, so I went with the “requests” library for easiness. I guess I can remove this dependency and use urllib3 which is already included in the python_modules directory. Will this be needed? Or more in general, is it preferred or needed to avoid having external dependencies?
Hope this is the right place to discuss this, but I can also open a github issue if needed.
we have urllib3 vendored, i suggest to use it, there is
No need to include it, make it optional like
I originally wanted to use UrlService, but I need to do both post and get http requests
just noticed it, let me see
Ok, i think the easiest way is to add it as is - with optional
PyJWTpackages. If there is interest in that module we rewrite it in
golangso we get rid of dependencies.
@ilyam8 thanks for your response. I’ll add the optional imports and will submit pull request. Maybe later I can change it to golang as well.