Netdata nightly fails to update

See my post here https://community.netdata.cloud/t/periodically-anacron-job-cron-daily-on-localhost-reports-a-problem-with-netdata-updater-sh/612 apparently this bug has crept into the updater script again this morning as the anacron job reported:

/tmp/netdata-updater-h2wewZhdXo/netdata-updater.sh: line 352: THIS_SHOULD_BE_REPLACED_BY_INSTALLER_SCRIPT: No such file or directory
run-parts: /etc/cron.daily/netdata-updater exited with return code 1

Running the kickstart scrip manually shows:

    chris@localhost:/var/crash$ bash <(curl -Ss https://my-netdata.io/kickstart.sh)
 --- Found existing install of Netdata under: / --- 
 --- Attempting to update existing install instead of creating a new one --- 
[/var/crash]$ sudo //usr/libexec/netdata/netdata-updater.sh --not-running-from-cron Checking if a newer version of the updater script is available.
Downloading newest version of updater script.
/tmp/netdata-updater-6QJ8iinT9b/netdata-updater.sh: line 354: THIS_SHOULD_BE_REPLACED_BY_INSTALLER_SCRIPT: No such file or directory
 FAILED  

 ABORTED  Failed to update existing Netdata install 

Running the kickstart script with the --reinstall option did successfully install the nightly update.

I’m also having this happen again

This is a known issue unintentionally introduced by some changes that were intended to make recovery from cases like this easier.

There’s an open PR to fix it (Fixed handling of environment file in updater script. by Ferroin · Pull Request #10447 · netdata/netdata · GitHub), but review has been a bit slow as many of our developers are still not back from vacation yet. Once that’s merged though, this issue should resolve itself without requiring any user intervention.

Thanks @Austin_Hemmelgarn, appreciate the updated info. I take it this is the reason that the nightly is still on v1.28.0-68-nightly?

I hate to be this vague, but the best I can say is that this is most likely the cause of being on that particular version still.

I’m a bit hesitant given recent history with the updater to say for certain that this is in fact the cause though, for all I know there could be another bug causing it in there somewhere (though I don’t think this is likely).

This morning there was an update from v1.28.0-68-nightly to v1.28.0-93-nightly. Running the kickstarter script gave the usual

bash <(curl -Ss https://my-netdata.io/kickstart.sh)
 --- Found existing install of Netdata under: / --- 
 --- Attempting to update existing install instead of creating a new one --- 
[/home/chris]$ sudo //usr/libexec/netdata/netdata-updater.sh --not-running-from-cron Checking if a newer version of the updater script is available.
Downloading newest version of updater script.
/tmp/netdata-updater-AaNchL31yc/netdata-updater.sh: line 354: THIS_SHOULD_BE_REPLACED_BY_INSTALLER_SCRIPT: No such file or directory
FAILED  

However running with --reinstall did work.